CVE-2023-23940: Openzeppelin cairo contracts OpenZeppelin Contracts Contains Improper Verification Vulnerability

MODERATE
Advisory Identifier: GHSA-626q-v9j4-mcp4
CVSS 5.3
CWE-345 CWE-347
Published
Advisory Summary

CVE-2023-23940 is a MODERATE (CVSS 5.3) openzeppelin contracts contains improper verification vulnerability (CWE-345: Insufficient Verification of Data Authenticity) affecting Openzeppelin cairo contracts libraries in the PyPI ecosystem. The issue involves openzeppelin contracts contains improper verification of cryptographic signature. Remediation is available by upgrading affected packages to version 0.6.1.

CVE-2023-23940 at a Glance

CVE Identifier CVE-2023-23940
GHSA Identifier GHSA-626q-v9j4-mcp4
Severity MODERATE
CVSS v3.1 Base Score 5.3
CWE Classification CWE-345: Insufficient Verification of Data Authenticity
Affected Product Openzeppelin cairo contracts
Package Ecosystem PyPI
Published Date
Last Updated

Security Impact

CVSS: 5.3

The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:N).

Attack Vector Network (AV:N)
Attack Complexity High (AC:H)
Privileges Required Low (PR:L)
User Interaction None (UI:N)
Scope Unchanged (S:U)
Confidentiality High (C:H)
Integrity None (I:N)
Availability None (A:N)

How to Fix CVE-2023-23940

To remediate this vulnerability, upgrade all affected Openzeppelin cairo contracts dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

openzeppelin-cairo-contracts fixed: 0.6.1
pip install openzeppelin-cairo-contracts>=0.6.1
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release:

pip show openzeppelin-cairo-contracts

How to Check if You Are Affected

To determine whether your Python environment is affected by CVE-2023-23940, inspect your installed packages using pip:

pip show openzeppelin-cairo-contracts

Analyze the terminal output to locate any version of Openzeppelin cairo contracts in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 0.6.1), your application is affected.

Note: The pip show openzeppelin-cairo-contracts command checks currently installed packages in your active Python environment.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-345: Insufficient Verification of Data Authenticity, where the product does not sufficiently verify the origin or authenticity of data, in a way that causes it to accept invalid data. In Openzeppelin cairo contracts, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

### Cause `is_valid_eth_signature` is missing a call to `finalize_keccak` after calling `verify_eth_signature`. ### Impact As a result, any contract using `is_valid_eth_signature` from the account library (such as the `EthAccount` preset) is vulnerable to a malicious sequencer. Specifically, the malicious sequencer would be able to bypass signature validation to impersonate an instance of these accounts. ### Risk In order to exploit this vulnerability, it is required to control a sequencer or prover since they're the ones executing the hints, being able to inject incorrect keccak results. Today StarkWare is the only party running both a prover or a sequencer, greatly reducing the risk of exploit. ### Patches The issue has been patched in 0.6.1. ### For more information If you have any questions or comments about this advisory: * Open an issue in [the Contracts for Cairo repository](https://github.com/OpenZeppelin/cairo-contracts/issues/new/choose) * Email us at [security@openzeppelin.com](mailto:security@openzeppelin.com)

CVE-2023-23940 Affected Openzeppelin cairo contracts Versions

1 component(s)
Fixed Versions:
0.6.1
Product / Package Ecosystem Affected Versions Fixed Version
openzeppelin-cairo-contracts
PyPI
≥ 0.2.0
< 0.6.1
0.6.1

References

Frequently Asked Questions

What is CVE-2023-23940?
CVE-2023-23940 is a security vulnerability in Openzeppelin cairo contracts involving OpenZeppelin Contracts contains Improper Verification of Cryptographic Signature under CWE-345: Insufficient Verification of Data Authenticity.
Which Openzeppelin cairo contracts versions are affected?
Affected versions include releases prior to 0.6.1 across affected packages: openzeppelin-cairo-contracts.
What version fixes CVE-2023-23940?
Upgrading to 0.6.1 (or the latest patched release for your respective branch) resolves the vulnerability.
Is openzeppelin-cairo-contracts affected?
Yes, openzeppelin-cairo-contracts is affected in releases prior to 0.6.1. Upgrade your dependency to 0.6.1 or later.
What is the CVSS score of CVE-2023-23940?
CVE-2023-23940 has a CVSS v3.1 base score of 5.3 (MODERATE) with vector string CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:N.
What CWE is associated with CVE-2023-23940?
CVE-2023-23940 is classified under CWE-345: Insufficient Verification of Data Authenticity (The product does not sufficiently verify the origin or authenticity of data, in a way that causes it to accept invalid data.).
How can I check PyPI dependencies for CVE-2023-23940?
Run the dependency tree command: 'pip show openzeppelin-cairo-contracts'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-626q-v9j4-mcp4",
  "modified" : "2024-10-07T21:19:33Z",
  "published" : "2023-02-02T16:59:46Z",
  "aliases" : [ "CVE-2023-23940" ],
  "summary" : "OpenZeppelin Contracts contains Improper Verification of Cryptographic Signature",
  "details" : "### Cause\n`is_valid_eth_signature` is missing a call to `finalize_keccak` after calling `verify_eth_signature`. \n\n### Impact\nAs a result, any contract using `is_valid_eth_signature` from the account library (such as the `EthAccount` preset) is vulnerable to a malicious sequencer. Specifically, the malicious sequencer would be able to bypass signature validation to impersonate an instance of these accounts.\n\n### Risk\nIn order to exploit this vulnerability, it is required to control a sequencer or prover since they're the ones executing the hints, being able to inject incorrect keccak results.\n\nToday StarkWare is the only party running both a prover or a sequencer, greatly reducing the risk of exploit.\n\n### Patches\nThe issue has been patched in 0.6.1.\n\n### For more information\nIf you have any questions or comments about this advisory:\n* Open an issue in [the Contracts for Cairo repository](https://github.com/OpenZeppelin/cairo-contracts/issues/new/choose)\n* Email us at [security@openzeppelin.com](mailto:security@openzeppelin.com)",
  "severity" : [ {
    "type" : "CVSS_V3",
    "score" : "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:N"
  }, {
    "type" : "CVSS_V4",
    "score" : "CVSS:4.0/AV:N/AC:L/AT:P/PR:L/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "PyPI",
      "name" : "openzeppelin-cairo-contracts"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0.2.0"
      }, {
        "fixed" : "0.6.1"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/OpenZeppelin/cairo-contracts/security/advisories/GHSA-626q-v9j4-mcp4"
  }, {
    "type" : "ADVISORY",
    "url" : "https://nvd.nist.gov/vuln/detail/CVE-2023-23940"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/OpenZeppelin/cairo-contracts/pull/542/commits/6d4cb750478fca2fd916f73297632f899aca9299"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/OpenZeppelin/cairo-contracts"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/pypa/advisory-database/tree/main/vulns/openzeppelin-cairo-contracts/PYSEC-2023-39.yaml"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-345", "CWE-347" ],
    "severity" : "MODERATE",
    "github_reviewed" : true,
    "github_reviewed_at" : "2023-02-02T16:59:46Z",
    "nvd_published_at" : "2023-02-03T20:15:00Z"
  }
}