Vulnerabilities in pkg:npm/@oneuptime/common-server

PACKAGE
Advisory Identifier: GHSA-246p-xmg8-wmcq
Share
Advisory Summary

CVE-2024-29194 is a HIGH (CVSS 8.3) oneuptime vulnerable to a privilege vulnerability (CWE-639: Authorization Bypass Through User-Controlled Key) affecting @oneuptime/model libraries in the npm ecosystem. The issue involves oneuptime vulnerable to a privilege escalation via local storage key manipulation. Remediation is available by upgrading affected packages to version 7.0.1815.

1 Known Advisory Record(s)
Package Vulnerability Intelligence

pkg:npm/@oneuptime/common-server

1 Known Advisory Record(s)

Vulnerability advisories affecting package pkg:npm/@oneuptime/common-server. Select an advisory below to view technical details or fixes.

Advisory ID CVE / NVD Severity Summary
GHSA-246p-xmg8-wmcq CVE-2024-29194 HIGH OneUptime Vulnerable to a Privilege Escalation via Local Storage Key Manipulation

CVE-2024-29194 at a Glance

CVE Identifier CVE-2024-29194
GHSA Identifier GHSA-246p-xmg8-wmcq
Severity HIGH
CVSS v3.1 Base Score 8.3
CWE Classification CWE-639: Authorization Bypass Through User-Controlled Key
Affected Product @oneuptime/model
Package Ecosystem npm
Published Date
Last Updated

Security Impact

CVSS: 8.3

The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:L).

Attack Vector Network (AV:N)
Attack Complexity Low (AC:L)
Privileges Required Low (PR:L)
User Interaction None (UI:N)
Scope Unchanged (S:U)
Confidentiality High (C:H)
Integrity High (I:H)
Availability Low (A:L)

How to Fix CVE-2024-29194

To remediate this vulnerability, upgrade all affected @oneuptime/model dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

@oneuptime/model fixed: 7.0.1815 
npm install @oneuptime/model@7.0.1815
@oneuptime/common-server fixed: 7.0.1815 
npm install @oneuptime/common-server@7.0.1815
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release: 

npm ls @oneuptime/model

How to Check if You Are Affected

To determine whether your Node.js application is affected by CVE-2024-29194, inspect your project dependencies using npm:

npm ls @oneuptime/model

Analyze the terminal output to locate any version of @oneuptime/model in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 7.0.1815), your application is affected.

Note: The npm ls @oneuptime/model command inspects dependencies declared in your package.json and lockfile; it does not perform automated runtime dynamic scanning.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-639: Authorization Bypass Through User-Controlled Key, where the system's authorization functionality does not prevent one user from gaining access to another user's data or record by modifying the key value identifying the data. In @oneuptime/model, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

## Summary A security vulnerability exists in oneuptime's local storage handling, where a regular user can escalate privileges by modifying the `is_master_admin` key to `true`. This allows unauthorized access to administrative functionalities. ## Details The vulnerability lies in the improper validation of client-side stored data within the web application. Specifically, the `is_master_admin` key, stored in the local storage of the browser, can be manipulated by an attacker. By changing this key from false to true, the application grants administrative privileges to the user, without proper server-side validation. ## POC (I am using Firefox Developer to demonstrate this vulnerability) Log in as a normal user. Open developer tools (hit F12), click Storage, then Local Storage. Modify the `is_master_admin` key from `false` to `true`. ## Impact This vulnerability represents a high security risk as it allows any authenticated user to gain administrative privileges through client-side manipulation. Most of the admin previlages were disabled except the user list. Where an attacker could see all the list of users who signed up to OneUptome. ## Patch This has been patched in 7.0.1815

CVE-2024-29194 Affected @oneuptime/model Versions

2 component(s)
Fixed Versions:
7.0.1815
Product / Package Ecosystem Affected Versions Fixed Version
@oneuptime/model
npm/@oneuptime/model
npm
< 7.0.1815
7.0.1815
@oneuptime/common-server
npm/@oneuptime/common-server
npm
< 7.0.1815
7.0.1815

References

GitHub Advisory / Wiki ADVISORY
https://github.com/OneUptime/oneuptime/security/advisories/GHSA-246p-xmg8-wmcq
NVD — CVE-2024-29194 NVD
https://nvd.nist.gov/vuln/detail/CVE-2024-29194
Security Fix Commit FIX COMMIT
https://github.com/OneUptime/oneuptime/commit/14016d23d834038dd65d3a96cf71af04b556a32c
@oneuptime/model Source Repository REPOSITORY
https://github.com/OneUptime/oneuptime

Frequently Asked Questions

What is CVE-2024-29194?
CVE-2024-29194 is a security vulnerability in @oneuptime/model involving OneUptime Vulnerable to a Privilege Escalation via Local Storage Key Manipulation under CWE-639: Authorization Bypass Through User-Controlled Key.
Which @oneuptime/model versions are affected?
Affected versions include releases prior to 7.0.1815 across affected packages: @oneuptime/model, @oneuptime/common-server.
What version fixes CVE-2024-29194?
Upgrading to 7.0.1815 (or the latest patched release for your respective branch) resolves the vulnerability.
Is @oneuptime/model affected?
Yes, @oneuptime/model is affected in releases prior to 7.0.1815. Upgrade your dependency to 7.0.1815 or later.
Is @oneuptime/common-server affected?
Yes, @oneuptime/common-server is affected in releases prior to 7.0.1815. Upgrade your dependency to 7.0.1815 or later.
What is the CVSS score of CVE-2024-29194?
CVE-2024-29194 has a CVSS v3.1 base score of 8.3 (HIGH) with vector string CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:L.
What CWE is associated with CVE-2024-29194?
CVE-2024-29194 is classified under CWE-639: Authorization Bypass Through User-Controlled Key (The system's authorization functionality does not prevent one user from gaining access to another user's data or record by modifying the key value identifying the data.).
How can I check npm dependencies for CVE-2024-29194?
Run the dependency tree command: 'npm ls @oneuptime/model'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
View Raw JSON 
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-246p-xmg8-wmcq",
  "modified" : "2024-03-25T19:37:27Z",
  "published" : "2024-03-25T19:37:27Z",
  "aliases" : [ "CVE-2024-29194" ],
  "summary" : "OneUptime Vulnerable to a Privilege Escalation via Local Storage Key Manipulation",
  "details" : "## Summary\nA security vulnerability exists in oneuptime's local storage handling, where a regular user can escalate privileges by modifying the `is_master_admin` key to `true`. This allows unauthorized access to administrative functionalities.\n\n## Details\nThe vulnerability lies in the improper validation of client-side stored data within the web application. Specifically, the `is_master_admin` key, stored in the local storage of the browser, can be manipulated by an attacker. By changing this key from false to true, the application grants administrative privileges to the user, without proper server-side validation. \n\n## POC\n(I am using Firefox Developer to demonstrate this vulnerability)\nLog in as a normal user. Open developer tools (hit F12), click Storage, then Local Storage. Modify the `is_master_admin` key from `false` to `true`.\n\n## Impact\nThis vulnerability represents a high security risk as it allows any authenticated user to gain administrative privileges through client-side manipulation. Most of the admin previlages were disabled except the user list. Where an attacker could see all the list of users who signed up to OneUptome. \n\n\n## Patch\nThis has been patched in 7.0.1815",
  "severity" : [ {
    "type" : "CVSS_V3",
    "score" : "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:L"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "npm",
      "name" : "@oneuptime/model"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0"
      }, {
        "fixed" : "7.0.1815"
      } ]
    } ]
  }, {
    "package" : {
      "ecosystem" : "npm",
      "name" : "@oneuptime/common-server"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0"
      }, {
        "fixed" : "7.0.1815"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/OneUptime/oneuptime/security/advisories/GHSA-246p-xmg8-wmcq"
  }, {
    "type" : "ADVISORY",
    "url" : "https://nvd.nist.gov/vuln/detail/CVE-2024-29194"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/OneUptime/oneuptime/commit/14016d23d834038dd65d3a96cf71af04b556a32c"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/OneUptime/oneuptime"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-639" ],
    "severity" : "HIGH",
    "github_reviewed" : true,
    "github_reviewed_at" : "2024-03-25T19:37:27Z",
    "nvd_published_at" : "2024-03-24T19:15:07Z"
  }
}