GHSA-wg2x-rv86-mmpx: @keep network/tbtc v2 SPV Merkle Proof Malleability Allows Vulnerability

{
  "schema_version" : "1.4.0",
  "id" : "GHSA-wg2x-rv86-mmpx",
  "modified" : "2024-01-19T22:07:47Z",
  "published" : "2024-01-19T22:07:47Z",
  "aliases" : [ ],
  "summary" : "SPV Merkle proof malleability allows the maintainer to prove invalid transactions",
  "details" : "## Summary\nBy publishing specially crafted transactions on the Bitcoin blockchain, the SPV maintainer can produce seemingly valid SPV proofs for fraudulent transactions.\n\nThe issue was originally identified by Least Authority in the tBTC Bridge V2 Security Audit Report as _Issue B: Bitcoin SPV Merkle Proofs Can Be Faked_. A mitigation was believed to have been in place, but this turned out to contain an error, and the issue had not been effectively mitigated.\n\n### Details\nThis is achieved by creating a 64-byte transaction that the fraudulent transaction treats as a node in its merkle proof:\n\nThe attacker creates the malicious transaction `E` and calculates an unusual but valid transaction `D`, so that the last 32 bytes of `D` are a part of the merkle proof of `E`:\n\n```\nD = foo | hash256(E')\nE' = bar | hash256(E)\n```\n\n`foo` and `bar` are arbitrary 32-byte values selected to facilitate this attack.\n\nThe attacker can then publish `D` and wait for it to be mined. A valid SPV proof for `D` can then be transformed into a proof for `E` by prepending `bar` and `foo` to the merkle proof, and changing the transaction index into one matching `E`'s implied position in the merkle tree.\n\nCalculating a suitable value for `E'` has been estimated to require between 2\\^60 to 2\\^81 operations. By contrast, the current Bitcoin hashrate is approximately 2\\^69. Thus the cost of performing the requisite brute-force is at most similar to, or possibly up to 1,000,000 times lower than, the cost of mining 6 Bitcoin blocks at the current difficulty.\n\n### Impact\nThe vulnerability does not enable the SPV maintainer to do anything they would not have been able to do otherwise. However, the ability to bypass the need to mine 6 blocks at the current difficulty makes abusing the SPV maintainer position significantly cheaper.\n\n### Patches\nAdding the coinbase transaction and its merkle proof into the SPV proofs prevents this issue, by increasing the brute-force required to 2\\^224. If the length of the coinbase proof matches the length of the transaction proof, and both proofs are valid for the same header, we can trust that the exploit has not been abused for the transaction.\n\n### Workarounds\nThe trusted SPV maintainer position prevents this issue\n\n### References\n[Weaknesses in Bitcoin’s Merkle Root Construction](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf)\n\n[Leaf-Node weakness in Bitcoin Merkle Tree Design](https://bitslog.com/2018/06/09/leaf-node-weakness-in-bitcoin-merkle-tree-design/)\n\n[SPV proof verification vulnerable to potential (but expensive to exploit) Merkle tree problem \\#192](https://github.com/summa-tx/bitcoin-spv/issues/192)\n\n[tBTC Bridge V2 Security Audit Report](https://leastauthority.com/static/publications/LeastAuthority_KeepNetwork_tBTC_Bridge_v2_Updated_Final_Audit_Report.pdf)",
  "severity" : [ ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "npm",
      "name" : "@keep-network/tbtc-v2"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0"
      }, {
        "fixed" : "1.5.2"
      } ]
    } ],
    "database_specific" : {
      "last_known_affected_version_range" : "<= 1.5.1"
    }
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/keep-network/tbtc-v2/security/advisories/GHSA-wg2x-rv86-mmpx"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/summa-tx/bitcoin-spv/issues/192"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/keep-network/tbtc-v2/commit/20a6fb1bfb23d4a3d5b90e00eaa7cc2abc9a2871"
  }, {
    "type" : "WEB",
    "url" : "https://bitslog.com/2018/06/09/leaf-node-weakness-in-bitcoin-merkle-tree-design"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/keep-network/tbtc-v2"
  }, {
    "type" : "WEB",
    "url" : "https://leastauthority.com/static/publications/LeastAuthority_KeepNetwork_tBTC_Bridge_v2_Updated_Final_Audit_Report.pdf"
  }, {
    "type" : "WEB",
    "url" : "https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf"
  } ],
  "database_specific" : {
    "cwe_ids" : [ ],
    "severity" : "HIGH",
    "github_reviewed" : true,
    "github_reviewed_at" : "2024-01-19T22:07:47Z",
    "nvd_published_at" : null
  }
}