CVE-2024-34341: Trix Trix Editor Arbitrary Code Execution Vulnerability

MODERATE
Advisory Identifier: GHSA-qjqp-xr96-cj99
CVSS 5.4
CWE-79
Published
Advisory Summary

CVE-2024-34341 is a MODERATE (CVSS 5.4) trix editor arbitrary code execution vulnerability (CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')) affecting Trix libraries in the npm ecosystem. The issue involves trix editor arbitrary code execution vulnerability. Remediation is available by upgrading affected packages to version 2.1.1, 1.3.2, 7.0.8.3, 7.1.3.3.

CVE-2024-34341 at a Glance

CVE Identifier CVE-2024-34341
GHSA Identifier GHSA-qjqp-xr96-cj99
Severity MODERATE
CVSS v3.1 Base Score 5.4
CWE Classification CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
Affected Product Trix
Package Ecosystem npm
Published Date
Last Updated

Security Impact

CVSS: 5.4

The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N).

Attack Vector Network (AV:N)
Attack Complexity Low (AC:L)
Privileges Required None (PR:N)
User Interaction Required (UI:R)
Scope Unchanged (S:U)
Confidentiality Low (C:L)
Integrity Low (I:L)
Availability None (A:N)

How to Fix CVE-2024-34341

To remediate this vulnerability, upgrade all affected Trix dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

trix fixed: 2.1.1
npm install trix@2.1.1
trix fixed: 1.3.2
npm install trix@1.3.2
actiontext fixed: 7.0.8.3
Upgrade actiontext to 7.0.8.3
actiontext fixed: 7.1.3.3
Upgrade actiontext to 7.1.3.3
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release:

npm ls trix

How to Check if You Are Affected

To determine whether your Node.js application is affected by CVE-2024-34341, inspect your project dependencies using npm:

npm ls trix

Analyze the terminal output to locate any version of Trix in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 2.1.1), your application is affected.

Note: The npm ls trix command inspects dependencies declared in your package.json and lockfile; it does not perform automated runtime dynamic scanning.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'), where the product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users. In Trix, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application. **Vulnerable Versions**: - 1.x series up to and including 1.3.1 - 2.x series up to and including 2.1.0 **Fixed Versions**: - v1.3.2 - v2.1.1 **Vector**: - **Bug 1**: When copying content manipulated by a script, such as: ```js document.addEventListener('copy', function(e){ e.clipboardData.setData('text/html', '<div><noscript><div class="123</noscript>456<img src=1 onerror=alert(1)//"></div></noscript></div>'); e.preventDefault(); }); ``` and pasting into the Trix editor, the script within the content is executed. - **Bug 2**: Similar execution occurs with content structured as: ```js document.write(`copy<div data-trix-attachment="{&quot;contentType&quot;:&quot;text/html&quot;,&quot;content&quot;:&quot;&lt;img src=1 onerror=alert(101)&gt;HELLO123&quot;}"></div>me`); ``` ### Impact: An attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed. ### Remediation: **Update Recommendation**: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content. **CSP Enhancement**: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem. ### References: - https://github.com/basecamp/trix/releases/tag/v2.1.1 - https://github.com/basecamp/trix/pull/1147 - https://github.com/basecamp/trix/pull/1149 - https://github.com/basecamp/trix/pull/1153 **Credit**: These issues were reported by security researchers [loknop](https://hackerone.com/loknop) and [pinpie](https://hackerone.com/pinpie).

CVE-2024-34341 Affected Trix Versions

4 component(s)
Fixed Versions:
2.1.11.3.27.0.8.37.1.3.3
Product / Package Ecosystem Affected Versions Fixed Version
trix
npm
≥ 2.0.0
< 2.1.1
2.1.1
trix
npm
≥ 0.9.0
< 1.3.2
1.3.2
actiontext
RubyGems
≥ 7.0.0.alpha1
< 7.0.8.3
7.0.8.3
actiontext
RubyGems
≥ 7.1.0.beta1
< 7.1.3.3
7.1.3.3

References

discuss.rubyonrails.org/t/xss-vulnerabiliti... WEB
https://discuss.rubyonrails.org/t/xss-vulnerabilities-in-trix-editor/85803
GitHub Advisory / Wiki ADVISORY
https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99
NVD — CVE-2024-34341 NVD
https://nvd.nist.gov/vuln/detail/CVE-2024-34341
Trix Source Repository REPOSITORY
https://github.com/basecamp/trix/pull/1147
Trix Source Repository REPOSITORY
https://github.com/basecamp/trix/pull/1149
Security Fix Commit FIX COMMIT
https://github.com/basecamp/trix/commit/1a5c68a14d48421fc368e30026f4a7918028b7ad
Security Fix Commit FIX COMMIT
https://github.com/basecamp/trix/commit/841ff19b53f349915100bca8fcb488214ff93554
Security Fix Commit FIX COMMIT
https://github.com/rails/rails/commit/07e6c88cc4defe6f6b8d28e79eb13a518e15b14c
Security Fix Commit FIX COMMIT
https://github.com/rails/rails/commit/260cb392fc1ee91d0b749cff08d1c8d54b230bd3
Security Fix Commit FIX COMMIT
https://github.com/rails/rails/commit/73fac32511eefdd45d8f00fecc2b8cc5408ea6d5
Trix Source Repository REPOSITORY
https://github.com/basecamp/trix
Trix Release RELEASE
https://github.com/basecamp/trix/releases/tag/v2.1.1
Trix Source Repository REPOSITORY
https://github.com/rubysec/ruby-advisory-db/blob/master/gems/actiontext/CVE-2024-34341.yml
rubyonrails.org/2024/5/17/rails-ver... WEB
https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-2-and-7-1-3-3-have-been-released
rubyonrails.org/2024/5/17/rails-ver... WEB
https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-3-has-been-released

Frequently Asked Questions

What is CVE-2024-34341?
CVE-2024-34341 is a security vulnerability in Trix involving Trix Editor Arbitrary Code Execution Vulnerability under CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting').
Which Trix versions are affected?
Affected versions include releases prior to 2.1.1, 1.3.2, 7.0.8.3, 7.1.3.3 across affected packages: trix, actiontext.
What version fixes CVE-2024-34341?
Upgrading to 2.1.1, 1.3.2, 7.0.8.3, 7.1.3.3 (or the latest patched release for your respective branch) resolves the vulnerability.
Is trix affected?
Yes, trix is affected in releases prior to 2.1.1, 1.3.2. Upgrade your dependency to 2.1.1, 1.3.2 or later.
Is actiontext affected?
Yes, actiontext is affected in releases prior to 7.0.8.3, 7.1.3.3. Upgrade your dependency to 7.0.8.3, 7.1.3.3 or later.
What is the CVSS score of CVE-2024-34341?
CVE-2024-34341 has a CVSS v3.1 base score of 5.4 (MODERATE) with vector string CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N.
What CWE is associated with CVE-2024-34341?
CVE-2024-34341 is classified under CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') (The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.).
How can I check npm dependencies for CVE-2024-34341?
Run the dependency tree command: 'npm ls trix'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-qjqp-xr96-cj99",
  "modified" : "2024-06-03T17:24:56Z",
  "published" : "2024-05-07T16:49:24Z",
  "aliases" : [ "CVE-2024-34341" ],
  "summary" : "Trix Editor Arbitrary Code Execution Vulnerability",
  "details" : "The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.\n\n**Vulnerable Versions**: \n\n- 1.x series up to and including 1.3.1\n- 2.x series up to and including 2.1.0\n\n**Fixed Versions**: \n\n- v1.3.2\n- v2.1.1\n\n**Vector**:\n\n- **Bug 1**: When copying content manipulated by a script, such as:\n\n```js\ndocument.addEventListener('copy', function(e){\n  e.clipboardData.setData('text/html', '<div><noscript><div class=\"123</noscript>456<img src=1 onerror=alert(1)//\"></div></noscript></div>');\n  e.preventDefault();\n});\n```\n\nand pasting into the Trix editor, the script within the content is executed.\n\n- **Bug 2**: Similar execution occurs with content structured as:\n\n```js\ndocument.write(`copy<div data-trix-attachment=\"{&quot;contentType&quot;:&quot;text/html&quot;,&quot;content&quot;:&quot;&lt;img src=1 onerror=alert(101)&gt;HELLO123&quot;}\"></div>me`);\n```\n\n### Impact:\nAn attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.\n\n### Remediation:\n\n**Update Recommendation**: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.\n\n**CSP Enhancement**: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.\n\n### References:\n  - https://github.com/basecamp/trix/releases/tag/v2.1.1\n  - https://github.com/basecamp/trix/pull/1147\n  - https://github.com/basecamp/trix/pull/1149\n  - https://github.com/basecamp/trix/pull/1153\n\n**Credit**: These issues were reported by security researchers [loknop](https://hackerone.com/loknop) and [pinpie](https://hackerone.com/pinpie).",
  "severity" : [ {
    "type" : "CVSS_V3",
    "score" : "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "npm",
      "name" : "trix"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "2.0.0"
      }, {
        "fixed" : "2.1.1"
      } ]
    } ]
  }, {
    "package" : {
      "ecosystem" : "npm",
      "name" : "trix"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0.9.0"
      }, {
        "fixed" : "1.3.2"
      } ]
    } ]
  }, {
    "package" : {
      "ecosystem" : "RubyGems",
      "name" : "actiontext"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "7.0.0.alpha1"
      }, {
        "fixed" : "7.0.8.3"
      } ]
    } ]
  }, {
    "package" : {
      "ecosystem" : "RubyGems",
      "name" : "actiontext"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "7.1.0.beta1"
      }, {
        "fixed" : "7.1.3.3"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99"
  }, {
    "type" : "ADVISORY",
    "url" : "https://nvd.nist.gov/vuln/detail/CVE-2024-34341"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/pull/1147"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/pull/1149"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/commit/1a5c68a14d48421fc368e30026f4a7918028b7ad"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/commit/841ff19b53f349915100bca8fcb488214ff93554"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/rails/rails/commit/07e6c88cc4defe6f6b8d28e79eb13a518e15b14c"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/rails/rails/commit/260cb392fc1ee91d0b749cff08d1c8d54b230bd3"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/rails/rails/commit/73fac32511eefdd45d8f00fecc2b8cc5408ea6d5"
  }, {
    "type" : "WEB",
    "url" : "https://discuss.rubyonrails.org/t/xss-vulnerabilities-in-trix-editor/85803"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/basecamp/trix"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/basecamp/trix/releases/tag/v2.1.1"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/rubysec/ruby-advisory-db/blob/master/gems/actiontext/CVE-2024-34341.yml"
  }, {
    "type" : "WEB",
    "url" : "https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-2-and-7-1-3-3-have-been-released"
  }, {
    "type" : "WEB",
    "url" : "https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-3-has-been-released"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-79" ],
    "severity" : "MODERATE",
    "github_reviewed" : true,
    "github_reviewed_at" : "2024-05-07T16:49:24Z",
    "nvd_published_at" : "2024-05-07T16:15:08Z"
  }
}