CVE-2019-1010259: Salt SQL Injection Vulnerability

CRITICAL
Advisory Identifier: GHSA-h8xp-h3jf-wv4v
Share
CVSS 9.8
CWE-89
Published
Advisory Summary

CVE-2019-1010259 is a CRITICAL (CVSS 9.8) sql injection vulnerability (CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')) affecting Salt libraries in the PyPI ecosystem. The issue involves saltstack salt sql injection vulnerability in mysql.user_chpass function. Remediation is available by upgrading affected packages to version 2018.3.4.

CVE-2019-1010259 at a Glance

CVE Identifier CVE-2019-1010259
GHSA Identifier GHSA-h8xp-h3jf-wv4v
Severity CRITICAL
CVSS v3.1 Base Score 9.8
CWE Classification CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
Affected Product Salt
Package Ecosystem PyPI
Published Date
Last Updated

Security Impact

CVSS: 9.8

The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H).

Attack Vector Network (AV:N)
Attack Complexity Low (AC:L)
Privileges Required None (PR:N)
User Interaction None (UI:N)
Scope Unchanged (S:U)
Confidentiality High (C:H)
Integrity High (I:H)
Availability High (A:H)

How to Fix CVE-2019-1010259

To remediate this vulnerability, upgrade all affected Salt dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

salt fixed: 2018.3.4 
pip install salt>=2018.3.4
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release: 

pip show salt

How to Check if You Are Affected

To determine whether your Python environment is affected by CVE-2019-1010259, inspect your installed packages using pip:

pip show salt

Analyze the terminal output to locate any version of Salt in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 2018.3.4), your application is affected.

Note: The pip show salt command checks currently installed packages in your active Python environment.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'), where the product constructs all or part of an sql command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended sql command when it is sent to a downstream component. without sufficient removal or quoting of sql syntax in user-controllable inputs, the generated sql query can cause those inputs to be interpreted as sql instead of ordinary user data. In Salt, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

SaltStack Salt 2018.3 is affected by: SQL Injection. The impact is: An attacker could escalate privileges on MySQL server deployed by cloud provider. It leads to RCE. The component is: The `mysql.user_chpass` function from the MySQL module for Salt (https://github.com/saltstack/salt/blob/develop/salt/modules/mysql.py#L1462). The attack vector is: specially crafted password string. The fixed version is: 2018.3.4.

CVE-2019-1010259 Affected Salt Versions

1 component(s)
Fixed Versions:
2018.3.4
Product / Package Ecosystem Affected Versions Fixed Version
salt
pypi/salt
PyPI
≥ 2018.3.0
< 2018.3.4
2018.3.4

References

NVD — CVE-2019-1010259 NVD
https://nvd.nist.gov/vuln/detail/CVE-2019-1010259
Salt Source Repository REPOSITORY
https://github.com/saltstack/salt/pull/51462
Security Fix Commit FIX COMMIT
https://github.com/ShantonRU/salt/commit/a46c86a987c78e74e87969d8d3b27094e6544b7a
Salt Source Repository REPOSITORY
https://github.com/pypa/advisory-database/tree/main/vulns/salt/PYSEC-2019-119.yaml
Salt Source Repository REPOSITORY
https://github.com/saltstack/salt
Salt Source Repository REPOSITORY
https://github.com/saltstack/salt/blob/f22de0887cd7167887f113bf394244b74fb36b6b/salt/modules/mysql.py#L1534

Frequently Asked Questions

What is CVE-2019-1010259?
CVE-2019-1010259 is a security vulnerability in Salt involving SaltStack Salt SQL Injection vulnerability in mysql.user_chpass function under CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection').
Which Salt versions are affected?
Affected versions include releases prior to 2018.3.4 across affected packages: salt.
What version fixes CVE-2019-1010259?
Upgrading to 2018.3.4 (or the latest patched release for your respective branch) resolves the vulnerability.
Is salt affected?
Yes, salt is affected in releases prior to 2018.3.4. Upgrade your dependency to 2018.3.4 or later.
What is the CVSS score of CVE-2019-1010259?
CVE-2019-1010259 has a CVSS v3.1 base score of 9.8 (CRITICAL) with vector string CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H.
What CWE is associated with CVE-2019-1010259?
CVE-2019-1010259 is classified under CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection') (The product constructs all or part of an SQL command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended SQL command when it is sent to a downstream component. Without sufficient removal or quoting of SQL syntax in user-controllable inputs, the generated SQL query can cause those inputs to be interpreted as SQL instead of ordinary user data.).
How can I check PyPI dependencies for CVE-2019-1010259?
Run the dependency tree command: 'pip show salt'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
View Raw JSON 
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-h8xp-h3jf-wv4v",
  "modified" : "2024-10-25T20:20:14Z",
  "published" : "2022-05-24T16:50:39Z",
  "aliases" : [ "CVE-2019-1010259" ],
  "summary" : "SaltStack Salt SQL Injection vulnerability in mysql.user_chpass function",
  "details" : "SaltStack Salt 2018.3 is affected by: SQL Injection. The impact is: An attacker could escalate privileges on MySQL server deployed by cloud provider. It leads to RCE. The component is: The `mysql.user_chpass` function from the MySQL module for Salt (https://github.com/saltstack/salt/blob/develop/salt/modules/mysql.py#L1462). The attack vector is: specially crafted password string. The fixed version is: 2018.3.4.",
  "severity" : [ {
    "type" : "CVSS_V3",
    "score" : "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "PyPI",
      "name" : "salt"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "2018.3.0"
      }, {
        "fixed" : "2018.3.4"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "ADVISORY",
    "url" : "https://nvd.nist.gov/vuln/detail/CVE-2019-1010259"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/saltstack/salt/pull/51462"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/ShantonRU/salt/commit/a46c86a987c78e74e87969d8d3b27094e6544b7a"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/pypa/advisory-database/tree/main/vulns/salt/PYSEC-2019-119.yaml"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/saltstack/salt"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/saltstack/salt/blob/f22de0887cd7167887f113bf394244b74fb36b6b/salt/modules/mysql.py#L1534"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-89" ],
    "severity" : "CRITICAL",
    "github_reviewed" : true,
    "github_reviewed_at" : "2024-04-22T22:33:06Z",
    "nvd_published_at" : "2019-07-18T17:15:00Z"
  }
}