GHSA-5v93-9mqw-p9mh: Orml rewards Uncaught Panic Vulnerability

HIGH
Share
CWE-248
Published
Advisory Summary

GHSA-5v93-9mqw-p9mh is a HIGH uncaught panic vulnerability (CWE-248: Uncaught Exception) affecting Orml rewards libraries in the crates.io ecosystem. The issue involves uncaught panic in orml rewards pallet. Remediation is available by upgrading affected packages to version 1.2.1.

GHSA-5v93-9mqw-p9mh at a Glance

CVE Identifier N/A
GHSA Identifier GHSA-5v93-9mqw-p9mh
Severity HIGH
CVSS v3.1 Base Score N/A
CWE Classification CWE-248: Uncaught Exception
Affected Product Orml rewards
Package Ecosystem crates.io
Published Date
Last Updated

How to Fix GHSA-5v93-9mqw-p9mh

To remediate this vulnerability, upgrade all affected Orml rewards dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

orml-rewards fixed: 1.2.1 
Upgrade orml-rewards to 1.2.1
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release: 

inspect dependencies for orml-rewards

How to Check if You Are Affected

To determine whether your application is affected by GHSA-5v93-9mqw-p9mh, inspect your project dependencies for Orml rewards:

inspect dependencies for orml-rewards

Analyze the terminal output to locate any version of Orml rewards in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 1.2.1), your application is affected.

Note: Verify declared build manifests and deployed runtime container environments.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-248: Uncaught Exception, where an exception is thrown from a function, but it is not caught. In Orml rewards, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

## Summary A vulnerability in the `add_share` function of the **Rewards** pallet (part of the ORML repository) can lead to an uncaught Rust panic when handling user-provided input exceeding the `u128` range. ## Affected Components - **ORML Rewards** pallet (`rewards/src/lib.rs`) - Any Substrate-based chain using ORML Rewards with `add_share` accepting unvalidated large `u128` inputs ## Technical Details - `add_share` performs arithmetic on user-supplied values (`add_amount`) of type `T::Share` (mapped to `u128` in Acala). - If `add_amount` is large enough (e.g., `i128::MAX`), the intermediate result may overflow and panic on the cast to `u128`. - Validation occurs only after arithmetic, enabling a crafted input to trigger an overflow. ## Impact A malicious user submitting a specially crafted extrinsic can cause a panic in the runtime: - **Denial of Service** by crashing the node process. - **Potential for invalid blocks** produced by validators. ## Likelihood This issue is exploitable in production if there exists at least one rewards pool where reward tokens exceed twice the collateral tokens, allowing sufficiently large multiplication to exceed `u128` bounds. ## Remediation - This issue is fixed in https://github.com/open-web3-stack/open-runtime-module-library/pull/1016 ## Backport The patch have been backported to following release branches: - polkadot-stable2407 - polkadot-stable2409 A 1.0.1 patch release is made with this fix.

GHSA-5v93-9mqw-p9mh Affected Orml rewards Versions

1 component(s)
Fixed Versions:
1.2.1
Product / Package Ecosystem Affected Versions Fixed Version
orml-rewards
 crates.io
< 1.2.1
1.2.1

References

GitHub Advisory / Wiki ADVISORY
https://github.com/open-web3-stack/open-runtime-module-library/security/advisories/GHSA-5v93-9mqw-p9mh
Orml rewards Source Repository REPOSITORY
https://github.com/open-web3-stack/open-runtime-module-library/pull/1016
Security Fix Commit FIX COMMIT
https://github.com/open-web3-stack/open-runtime-module-library/commit/6720fcd92f44e5f204741b04fdef3b67b0fcf6bc
Orml rewards Source Repository REPOSITORY
https://github.com/open-web3-stack/open-runtime-module-library

Frequently Asked Questions

What is GHSA-5v93-9mqw-p9mh?
GHSA-5v93-9mqw-p9mh is a security vulnerability in Orml rewards involving Uncaught Panic in ORML Rewards Pallet under CWE-248: Uncaught Exception.
Which Orml rewards versions are affected?
Affected versions include releases prior to 1.2.1 across affected packages: orml-rewards.
What version fixes GHSA-5v93-9mqw-p9mh?
Upgrading to 1.2.1 (or the latest patched release for your respective branch) resolves the vulnerability.
Is orml-rewards affected?
Yes, orml-rewards is affected in releases prior to 1.2.1. Upgrade your dependency to 1.2.1 or later.
What CWE is associated with GHSA-5v93-9mqw-p9mh?
GHSA-5v93-9mqw-p9mh is classified under CWE-248: Uncaught Exception (An exception is thrown from a function, but it is not caught.).
How can I check crates.io dependencies for GHSA-5v93-9mqw-p9mh?
Run the dependency tree command: 'inspect dependencies for orml-rewards'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
View Raw JSON 
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-5v93-9mqw-p9mh",
  "modified" : "2025-02-14T17:26:08Z",
  "published" : "2025-02-14T17:26:08Z",
  "aliases" : [ ],
  "summary" : "Uncaught Panic in ORML Rewards Pallet",
  "details" : "## Summary\nA vulnerability in the `add_share` function of the **Rewards** pallet (part of the ORML repository) can lead to an uncaught Rust panic when handling user-provided input exceeding the `u128` range.\n\n## Affected Components\n- **ORML Rewards** pallet (`rewards/src/lib.rs`)\n- Any Substrate-based chain using ORML Rewards with `add_share` accepting unvalidated large `u128` inputs\n\n## Technical Details\n- `add_share` performs arithmetic on user-supplied values (`add_amount`) of type `T::Share` (mapped to `u128` in Acala).\n- If `add_amount` is large enough (e.g., `i128::MAX`), the intermediate result may overflow and panic on the cast to `u128`.\n- Validation occurs only after arithmetic, enabling a crafted input to trigger an overflow.\n\n## Impact\nA malicious user submitting a specially crafted extrinsic can cause a panic in the runtime:\n- **Denial of Service** by crashing the node process.\n- **Potential for invalid blocks** produced by validators.\n\n## Likelihood\nThis issue is exploitable in production if there exists at least one rewards pool where reward tokens exceed twice the collateral tokens, allowing sufficiently large multiplication to exceed `u128` bounds.\n\n## Remediation\n- This issue is fixed in https://github.com/open-web3-stack/open-runtime-module-library/pull/1016\n\n## Backport\n\nThe patch have been backported to following release branches:\n- polkadot-stable2407\n- polkadot-stable2409\n\nA 1.0.1 patch release is made with this fix.",
  "severity" : [ {
    "type" : "CVSS_V4",
    "score" : "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:L/VA:H/SC:N/SI:N/SA:N"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "crates.io",
      "name" : "orml-rewards"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0"
      }, {
        "fixed" : "1.2.1"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/open-web3-stack/open-runtime-module-library/security/advisories/GHSA-5v93-9mqw-p9mh"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/open-web3-stack/open-runtime-module-library/pull/1016"
  }, {
    "type" : "WEB",
    "url" : "https://github.com/open-web3-stack/open-runtime-module-library/commit/6720fcd92f44e5f204741b04fdef3b67b0fcf6bc"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/open-web3-stack/open-runtime-module-library"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-248" ],
    "severity" : "HIGH",
    "github_reviewed" : true,
    "github_reviewed_at" : "2025-02-14T17:26:08Z",
    "nvd_published_at" : null
  }
}