CVE-2024-34694: Lnbits LNbits Improperly Handles Potential Network Vulnerability

HIGH
Advisory Identifier: GHSA-3j4h-h3fp-vwww
Share
CVSS 8.1
CWE-754
Published
Advisory Summary

CVE-2024-34694 is a HIGH (CVSS 8.1) lnbits improperly handles potential network vulnerability (CWE-754: Improper Check for Unusual or Exceptional Conditions) affecting Lnbits libraries in the PyPI ecosystem. The issue involves lnbits improperly handles potential network and payment failures when using eclair backend. Remediation is available by upgrading affected packages to version 0.12.6.

CVE-2024-34694 at a Glance

CVE Identifier CVE-2024-34694
GHSA Identifier GHSA-3j4h-h3fp-vwww
Severity HIGH
CVSS v3.1 Base Score 8.1
CWE Classification CWE-754: Improper Check for Unusual or Exceptional Conditions
Affected Product Lnbits
Package Ecosystem PyPI
Published Date
Last Updated

Security Impact

CVSS: 8.1

The security impact metrics below are parsed directly from the CVSS v3.1 vector string (CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H).

Attack Vector Network (AV:N)
Attack Complexity Low (AC:L)
Privileges Required Low (PR:L)
User Interaction None (UI:N)
Scope Unchanged (S:U)
Confidentiality None (C:N)
Integrity High (I:H)
Availability High (A:H)

How to Fix CVE-2024-34694

To remediate this vulnerability, upgrade all affected Lnbits dependencies to a patched release. Both direct and transitive dependencies should be checked, as frameworks or security libraries may pull in vulnerable versions transitively.

lnbits fixed: 0.12.6 
pip install lnbits>=0.12.6
Verify Direct and Transitive Dependencies

Run the following command in your project directory to verify that all resolved dependencies use the patched release: 

pip show lnbits

How to Check if You Are Affected

To determine whether your Python environment is affected by CVE-2024-34694, inspect your installed packages using pip:

pip show lnbits

Analyze the terminal output to locate any version of Lnbits in your dependency tree. If any resolved version matches the vulnerable ranges listed in the table below (for example, versions earlier than 0.12.6), your application is affected.

Note: The pip show lnbits command checks currently installed packages in your active Python environment.

Technical Details

Vulnerability Mechanism & Technical Analysis

This vulnerability is classified under CWE-754: Improper Check for Unusual or Exceptional Conditions, where the product does not check or incorrectly checks for unusual or exceptional conditions that are not expected to occur frequently during day to day operation of the product. In Lnbits, software state validation or input boundaries are circumvented during processing. Review the official source advisory statement below for specific affected components, classes, and reproduction details.

Source Advisory Statement

### Summary Paying invoices in Eclair that do not get settled within the internal timeout (about 30s) lead to a payment being considered failed, even though it may still be in flight. ### Details Using `blocking: true` on the API call will lead to a timeout error if a payment does not get settled in the 30s timeout with the error: `Ask timed out on [Actor[akka://eclair-node/user/$l#134241942]] after [30000 ms]. Message of type [fr.acinq.eclair.payment.send.PaymentInitiator$SendPaymentToNode]. A typical reason for AskTimeoutException is that the recipient actor didn't send a reply.` https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L138 This is considered a payment failure by parts of the code, and assumes the payment is not going to be settled after: https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L144 https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L141 https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L146 The best way to fix this is to check the payment status after an error, and when not sure, always consider a payment still in flight. ### PoC A very simple way to exploit this is: - Create a hold invoice - Pay the invoice with the LNbits server backed by an Eclair node, until it times out - Settle the hold invoice ### Impact This vulnerability can lead to a total loss of funds for the node backend.

CVE-2024-34694 Affected Lnbits Versions

1 component(s)
Fixed Versions:
0.12.6
Product / Package Ecosystem Affected Versions Fixed Version
lnbits
pypi/lnbits
PyPI
< 0.12.6
0.12.6

References

GitHub Advisory / Wiki ADVISORY
https://github.com/lnbits/lnbits/security/advisories/GHSA-3j4h-h3fp-vwww
NVD — CVE-2024-34694 NVD
https://nvd.nist.gov/vuln/detail/CVE-2024-34694
Lnbits Source Repository REPOSITORY
https://github.com/lnbits/lnbits

Frequently Asked Questions

What is CVE-2024-34694?
CVE-2024-34694 is a security vulnerability in Lnbits involving LNbits improperly handles potential network and payment failures when using Eclair backend under CWE-754: Improper Check for Unusual or Exceptional Conditions.
Which Lnbits versions are affected?
Affected versions include releases prior to 0.12.6 across affected packages: lnbits.
What version fixes CVE-2024-34694?
Upgrading to 0.12.6 (or the latest patched release for your respective branch) resolves the vulnerability.
Is lnbits affected?
Yes, lnbits is affected in releases prior to 0.12.6. Upgrade your dependency to 0.12.6 or later.
What is the CVSS score of CVE-2024-34694?
CVE-2024-34694 has a CVSS v3.1 base score of 8.1 (HIGH) with vector string CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H.
What CWE is associated with CVE-2024-34694?
CVE-2024-34694 is classified under CWE-754: Improper Check for Unusual or Exceptional Conditions (The product does not check or incorrectly checks for unusual or exceptional conditions that are not expected to occur frequently during day to day operation of the product.).
How can I check PyPI dependencies for CVE-2024-34694?
Run the dependency tree command: 'pip show lnbits'. This command lists direct and transitive dependencies in your build configuration so you can verify if a vulnerable version is resolved.
Machine-readable OSV JSON OSV v1.5 Schema
Normalized schema output
View Raw JSON 
{
  "schema_version" : "1.4.0",
  "id" : "GHSA-3j4h-h3fp-vwww",
  "modified" : "2024-06-17T21:24:18Z",
  "published" : "2024-06-17T21:24:18Z",
  "aliases" : [ "CVE-2024-34694" ],
  "summary" : "LNbits improperly handles potential network and payment failures when using Eclair backend",
  "details" : "### Summary\n\nPaying invoices in Eclair that do not get settled within the internal timeout (about 30s) lead to a payment being considered failed, even though it may still be in flight.\n\n### Details\n\nUsing `blocking: true` on the API call will lead to a timeout error if a payment does not get settled in the 30s timeout with the error: `Ask timed out on [Actor[akka://eclair-node/user/$l#134241942]] after [30000 ms]. Message of type [fr.acinq.eclair.payment.send.PaymentInitiator$SendPaymentToNode]. A typical reason for AskTimeoutException is that the recipient actor didn't send a reply.`\nhttps://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L138\n\nThis is considered a payment failure by parts of the code, and assumes the payment is not going to be settled after:\nhttps://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L144\nhttps://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L141\nhttps://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L146\n\nThe best way to fix this is to check the payment status after an error, and when not sure, always consider a payment still in flight.\n\n### PoC\n\nA very simple way to exploit this is:\n- Create a hold invoice\n- Pay the invoice with the LNbits server backed by an Eclair node, until it times out\n- Settle the hold invoice\n\n### Impact\n\nThis vulnerability can lead to a total loss of funds for the node backend.\n",
  "severity" : [ {
    "type" : "CVSS_V3",
    "score" : "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H"
  } ],
  "affected" : [ {
    "package" : {
      "ecosystem" : "PyPI",
      "name" : "lnbits"
    },
    "ranges" : [ {
      "type" : "ECOSYSTEM",
      "events" : [ {
        "introduced" : "0"
      }, {
        "fixed" : "0.12.6"
      } ]
    } ]
  } ],
  "references" : [ {
    "type" : "WEB",
    "url" : "https://github.com/lnbits/lnbits/security/advisories/GHSA-3j4h-h3fp-vwww"
  }, {
    "type" : "ADVISORY",
    "url" : "https://nvd.nist.gov/vuln/detail/CVE-2024-34694"
  }, {
    "type" : "PACKAGE",
    "url" : "https://github.com/lnbits/lnbits"
  } ],
  "database_specific" : {
    "cwe_ids" : [ "CWE-754" ],
    "severity" : "HIGH",
    "github_reviewed" : true,
    "github_reviewed_at" : "2024-06-17T21:24:18Z",
    "nvd_published_at" : "2024-06-14T15:15:50Z"
  }
}